https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40675
Bernard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185791|0 |1 is obsolete| | --- Comment #3 from Bernard <[email protected]> --- Created attachment 185792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185792&action=edit Bug 40675 Removes carriage returns from messages to prevent breaking SIP - new regex to prevent regression. I am told my original patch could cause a regression and should instead be $value =~ s/\r\n|\r|\n/ /g; "We probably really want to normalise all options to a space as opposed to switching options. My original change switches us from Mac CR characters to Windows combination of CRLF (and unit tends to just stick to LF in the olden days).. so to really fix the bug we should look for all three as above." Test 1. Find a user and click "Add message". 2. Choose "Add message for OPAC ... " from dropdown 3. In Word (or similar, type a message adding a carriage return in the middle of it. 4. Copy / paste this text into the message box and save. 5. Run the SIP emulator tool sip_cli_emulator.pl and observe that after the carriage return, the message has broken onto a new line. 6. Install patch 7. restart_all 8. Repeat above 1-5 9. Observe that runaway line is now joined to the previous line (correctly) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
