https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761

--- Comment #70 from Lucas Gass (lukeg) <[email protected]> ---
(In reply to Tomás Cohen Arazi (tcohen) from comment #69)
> (In reply to Tomás Cohen Arazi (tcohen) from comment #67)
> > (In reply to Lucas Gass (lukeg) from comment #66)
> > > There is a stray </form> tag in your modal. I also see this failure:
> > > 
> > > 
> > > [FAIL] installer/data/mysql/kohastructure.sql
> > >    FAIL     tinyint_has_boolean_flag
> > >           The new column sftp_servers.passive is using TINYINT(1) as type 
> > > but is not
> > > defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm),
> > > see the SQL12 coding guideline
> > >           The new column sftp_servers.debug is using TINYINT(1) as type 
> > > but is not
> > > defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm),
> > > see the SQL12 coding guideline
> > 
> > My previous follow-ups addressed those issues amongst others. I marked them
> > as obsolete once I understood that Martin's follow-up bug basically rewrites
> > it all.
> 
> ^^^ Lucas
> 
> Don't look at this bug alone. Apply the them together with 39190. Because of
> what I said. I already posted fixes to all the issues, but it turns out it
> all gets rewritten there.


Ah, my misunderstanding. Sorry! I was reviewing this bug without the others
applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to