https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20638
--- Comment #34 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Thanks Lisette for testing! I found out the `C4::Log::actionlog` method is actually performing an implicit `$infos->get_from_storage()` which breaks the logic I implemented, as my original implementation was: 1. modify the object ($self) 2. create an unmodified copy of the object ($self->get_from_storage) [1] 3. pass both to `logaction()` 4. call `store()` So it was always comparing the untouched object with itself, even though I was passing a modified one! I changed it to match what `actionlog` is designed to, even though I dislike this a lot :-D. About [1] I opted to use `clone` and save a DB query. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
