https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866
Andrew Fuerste-Henry <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187630|0 |1 is obsolete| | --- Comment #24 from Andrew Fuerste-Henry <[email protected]> --- Created attachment 187680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187680&action=edit Bug 40866: Remove original Bug 9762 implementation remnants (Part 2 - Renewals) This patch removes the duplicate logging code from renewal scripts (circ/renew.pl and svc/renew) that was part of the original Bug 9762 implementation. The original implementation created separate logaction() calls with custom JSON messages whenever renewal overrides occurred. This caused double logging alongside the Alternative implementation which properly logs overrides via the confirmations parameter in AddRenewal. Changes: circ/renew.pl: - Removed unused variables: $user, $branchcode, @message - Removed separate logaction() calls for override logging - Changed to use confirmations array with proper codes: * 'RENEWAL_LIMIT' for override_limit * 'ON_RESERVE' for override_holds - Removed C4::Log qw(logaction) import svc/renew: - Removed unused variables: $borrower, $user, $message, @message - Removed separate logaction() calls for override logging - Changed to use confirmations array with proper codes: * 'ON_RESERVE' for on_reserve override * 'RENEWAL_LIMIT' for too_many override - Removed C4::Log qw(logaction) import The Alternative implementation in AddRenewal will now handle all override logging consistently through the confirmations parameter. Signed-off-by: Andrew Fuerste Henry <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
