https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245
--- Comment #20 from Jonathan Druart <[email protected]> --- (In reply to CJ Lynce from comment #18) > (In reply to Jonathan Druart from comment #16) > > 5. > > (In reply to Lucas Gass (lukeg) from comment #14) > > > Should we add a Cypress test? > > I might need some help on this one, I've not written Cypress tests before. > Is there a past bug or two that has some good Koha-related examples to look > at? I have spent some time to write some tests for main. And all the bugs in the queue should be based on it. See bug 41003. You will see that your patch breaks it (because of the changes in autocomplete, other_name is now missing) We already have: Bug 40958 - Move patron_to_html (from js-patron-format.inc) to a standalone JS file Bug 40995 - Patron search autocomplete adds extraneous spacing and punctuation when patron lacks surname In this second one I suggested to use patron-format for the autocomplete result. I think it is good for this change (40245) actually: you won't need to adjust much patron_autocomplete, only to pass the "show first if different" flag. (In reply to CJ Lynce from comment #19) > (In reply to Jonathan Druart from comment #15) > > I think we should have "Patron" and "Firstname" in the name of the pref. The > > current version "ShowFirstIfDifferentThanPreferred" is confusing IMO. > > Is there a limit on how long a system pref name could/should be? > ShowPatronFirstnameIfDifferentThanPreferredname is more clear, but long (48 > chr) > It is shorter than PatronSelfRegistrationExpireTemporaryAccountsDelay (51 > chr) The max length is 50. And PatronSelfRegistrationExpireTemporaryAccountsDelay is 50 char length ;) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
