https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37196
--- Comment #18 from Alexander Wagner <[email protected]> --- (In reply to Angela Berrett from comment #17) > Was it decided if this would or would not be a sys pref that can be turned > on/off? WRT the final implementation there was no decision yet. However, we discussed the issue during the 2nd German Hackfest in Göttingen, hence the rebase by Paul, as he rightly observed the patch did not apply any more due to formatting changes upstream. In the context of said Hackfest we discussed automatic punctuation in general and there was quite some interest from the participants. (German union catalogues tend to not add punctuation as here the chars were always added for display automatically.) Due to this higher level of interest in a certain subgroup, the suggestion was to first implement the functionality as a plug in which could speed things up a bit. (Cf. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40972 for the necessary hook.) Then its also up to you to enable the plug in or not. Also note that in view of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21303 (the parent of this bug here) the general goal is to improve compliance of Koha to the Marc standard by observing the leader 18 instead of ignoring it. So, regardless of sysprefs there will always be a switch for this behaviour via the Marc leader. (IOW Automatic punctuation is only added if the leader _explicitly requests_ it on record level. This would be much finer grained than a global switch.) You may notice that currently Koha is implementing sort of a "random mixture" between automatic and manual punctuation even up to the point that manual punctuation gets stripped and replaced by automatic punctuation for some fields. (cf. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40300 and the discussion therein. The behaviour as outlined by the OP is implemented for various fields in the XSLTs where you even have to keep opac and intranet in sync.) As for a syspref I think one could follow https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40300#c11 However, pondering more on the discussion in Göttingen and bug 40972, I wonder if not a more general and flexible solution would be a syspref that allows to add and enable/disable Marc Filters in general. IMHO Koha should have a way to add Marc Filters also without patching XSLT.pm to be more flexible and transparent which ones are applied. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
