http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577
Galen Charlton <gmcha...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #3 from Galen Charlton <gmcha...@gmail.com> --- (In reply to Katrin Fischer from comment #2) > Galen, I think I found a problem with this - you said it's never used, but > from the description I thought about the funds page and spotted a problem > there: > > - Apply the patch > - Go to the funds page > - The heading is missing the budget information now - it shows: > Funds for '' > > I think this is a design issue of the funds page really. Maybe we just > should add a budget column to the table and reword the heading so it can > deal with funds from multiple budgets? But not sure how that would affect > other functionality on that page. Good catch. The funds page appears to still partially reflect an (old?) assumption that there would be only one active budget at a time. That assumption is nonsense nowadays, so I still believe that I'm on the right track with the change I made to GetBudgetPeriod(). Of course, it does need to be accompanied by a follow-up so that we don't have the Funds for '' situation. My proposal: - add a column for the parent budget (should it always be displayed, or only when no specific budget_period_id is passed?) - adjust the code that generates the hover to make sure that the parent budget is supplied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/