https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245
--- Comment #16 from Jonathan Druart <[email protected]> --- 1. What does "showlegal" mean? 2. var showFirstIfDifferentThanPreferred = [% Koha.Preference('ShowFirstIfDifferentThanPreferred') | html %]; Should be var showFirstIfDifferentThanPreferred = [% Koha.Preference('ShowFirstIfDifferentThanPreferred') ? 1 : 0 | html %]; To prevent a JS error if the pref is not set. 3. js-patron-format.inc is going to be removed on bug 40958, in favor of a js file, and the TT variable won't be accessible. Why don't you pass the "showFirstIfDifferentThanPreferred" flag from the patron search if the pref is set? You won't need to check the pref in the inc file 4. Commit message states that it affects "search results and autosuggestions" but it's actually all patron searches (bug title should also be adjusted) 5. (In reply to Lucas Gass (lukeg) from comment #14) > Should we add a Cypress test? Yes, that would be great! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
