https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off Depends on|40982 | Text to go in the| |Restore the ability to release notes| |define a default sort order | |for the holdings table at | |the OPAC. | |It replaces the system | |preference | |"OPACHoldingsDefaultSortFie | |ld" that had been broken | |for a while. Note that its | |value is not migrated. --- Comment #29 from Jonathan Druart <[email protected]> --- (In reply to Martin Renvoize (ashimema) from comment #27) > Hmm, > > 1) OPAC datatables.js lacks force_visibility - The OPAC version doesn't have > _dt_force_visibility() function like staff interface, so are we sure this is > working for the OPAC? Indeed, it's not needed at the OPAC. force_visibility has been introduced to force visiblity to restore DT's state. And it is not available for OPAC tables. > 2) Could we perhaps use the following for ordering instead of relying on > indexes that may well change with future work: > > // Find column by name instead of index > let current_location_col = holdingst_table_settings.columns.findIndex( > c => c.columnname == 'item_current_location' > ); > holdingst_table_settings.default_sort_order = current_location_col; Maybe, I don't know. We are storing/manipulating the index in the yaml and the DB for default_sort_order. We could try and see if it's possible to remove the index completely and use the column's names everywhere, but that's for another day :) > 3) We need to make it clear in the release notes that the preference content > is not migrated into the dt configs Added something to the release notes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40982 [Bug 40982] Basket: Orders table — "Modify" and "Cancel order" columns missing or displayed incorrectly -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
