https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320
--- Comment #111 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Hi, I tested the feature and am happy with what I see * functionality * aesthetics * usability The only annoyance I found was the page reload when using the breadcrumb. I'm not sure if it was a 'feature', but I fixed it with a follow-up. I also adjusted the commit titles to silence the QA tools a bit. At this point I think this deserves some squashing too. But that's not a blocker anyway. I wasn't able to run the tests successfully. What I did: 1. Apply the patches 2. Run: $ ktd --shell k$ sudo yarn install --modules-folder /kohadevbox/node_modules k$ yarn build 3. Run: k$ run_cypress --spec t/cypress/integration/ERM/ModuleDashboard_spec.ts => FAIL: The 'Latest SUSHI Counter jobs' tests fail with a page error: ``` Error: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection. > JS Warning detected: "[Vue warn]: Unhandled error during execution of setup function" "\n" " at <RouterLink" "key=0" "to=" {"name":"ERMHome","params":{"erm_usage_data_provider_id":"1"}} "class=\"\"" ">" "\n" " at <NavigationItem" "key=0" "item=" [object Object] "params=" {"erm_usage_data_provider_id":"1"} ">" "\n" " at <Breadcrumbs>" "\n" " at <App>" When Cypress detects uncaught errors originating from your application it will automatically fail the current test. This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event. ``` Hope it is an easy fix for y'all. Otherwise, great job! Hope to see some work for the admin home page and we start unifying it all :-D -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
