https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190
--- Comment #194 from Chloé Zermatten <[email protected]> --- (In reply to Michaela Sieber from comment #193) > We tested several hours and I will provide more feedback this week but here > are the most relevant Bugs we found: > > 1.) Migration scenario > > have some overdue rule, then apply the patch and do updatabase and yarn buid > > Error 404 in staff interface > > Please see Pedros comment 192 > > In your testplan in comment 183 you write in > > Part 11: Data Integrity & Persistence > 5. Check the database circulation_rules table: > - Verify the overdue_X_has_rules rule kind is present > > Is this the missing piece for the migrated data ? > > > 2.) Adding a trigger for a combination that exists in circ rules > > it is not possible to configure an overdue trigger with a combination that > already exists as a circulation rule. > > Example to reproduce in ktd with test data: > > - Go to circ rules (/cgi-bin/koha/admin/smart-rules.pl) > - Set a rule for All Libraries / All patron categories / Itemtype Books > - Check via SQL: select * from circulation_rules > - Go to overdue rules (/cgi-bin/koha/admin/circulation_triggers ) > - Set a rule for All Libraries / All patron categories / All Itemtype > - Now try to edit the delay for the applied rule > with combination All Libraries / All patron categories / Itemtype Books > --> Message in blue box "Your changes could not be saved as this > circulation > trigger was updated elsewhere. Please see the updated trigger below." > It is not possible to save / submit > - Now edit the delay for the applied rule > with combination All Libraries / Patron category Homebound / Itemtype > Books > --> You can save without problems, if this combination does not exist in > the database table circulation_rules > > > 3.) Permissions Error if you are not an admin > > The Overlay rules are part of the tools and also the permission is part of > the tools section. That means that it was enough to give users the > edit_notice_status_triggers permission, it was not neccessary to give any > administration permission (parameters) . > Now you moved the overdue triggers to administration. > > If you now log in as a person with edit_notice_status_triggers permission > you can see the tools module and click on the menu for overdue triggers but > then you get the error message "Something went wrong: Error: Authorization > failure. Missing required permission(s)." > > > 4.) Edit an existing trigger does not pull delay from database > > Edit an existing trigger and check that the delay value is 0 , it is not > pulled from the database. This is confusing and dangerous because you see > the delay value just a few centimeters above in the table. > If you save the form, the value in the database is overwritten with 0. > > To reproduce: follow testplan in comment 183 Part 4.3 Thank you for the testing and feedback, much appreciated! Re - 1.) overdue_X_has_rules is a property indicating that some rule(s) exist for a given context/trigger number combination. The most recent version of the integration ensure it is created whenever any rule is created for a given context/trigger number combination. The staff clients relies on this to ascertain whether a rule set exists efficiently. I think the solution might be to have it added to each existing context/trigger number combination - would that be sensible? 2., 3., and 4.: I will do some debugging and put patches together for those, many thanks for reporting them! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
