https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41145
--- Comment #5 from Alex Buckley <[email protected]> --- We have a partner library also seeing patron attribute logging even when there is no change made. This only happens for patron imports (either via the 'Import patron' tool in the staff client or running the import_patrons.pl script). Editing a patron account in the staff client and saving the attributes (without making any changes) does not generate extraneous log entries. Reviewing the logs from the patron imports, we see that the 'before' value is always blank, like so: { "attribute.INSTID" : { "after" : "value", "before" : "" } } This is the case even if the patron attribute actually did have an existing value. Debugging the code I think this blanking of the existing patron attribute value results in Koha logging a patron attribute change, because it regards the patron import as setting a value for a blank attribute. Even though that is no actually the case. The existing patron attribute is being blanked by https://git.koha-community.org/Koha-community/Koha/src/commit/74d5af9b39ab1f6e66e9e94f6335e29f5ecc60a0/Koha/Patrons/Import.pm#L382 I don't think that line should be there, otherwise we cannot pass a 'before' value through to Koha/Patron->extended_attributes() in the next line for logging. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
