https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125

--- Comment #28 from Arthur Suzuki <[email protected]> ---
(In reply to Jonathan Druart from comment #26)
> 1. We should avoid such raw SQL queries.
> 
> Cannot you do something like
> - loop on orders
> - use ->claims->filter_by_late (or use ->claimed_date)
> 
> And use Koha::Objects everywhere?
> 
> 2. We need to tests (and so move the code to methods)
> 
> 3. We need try-catch and better error handling.

ups uploaded a new patch a bit too soon, I only fixed the first part so far.
I will push a new patch soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to