https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364
Lucas Gass (lukeg) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190122|0 |1 is obsolete| | --- Comment #2 from Lucas Gass (lukeg) <[email protected]> --- Created attachment 190124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190124&action=edit Bug 41364: Fix error in preservation module breadcrumb This patch makes the 'Processings' breadcrum element not be tied to a component but a plain string with the link disabled. This was causing errors: - Breadcrumb element empty - Error in the browser console To test: 1. Enable the Preservation module 2. Go to Home > Preservation > Settings 3. Use the 'Add a new processing' button => FAIL: The breadcrumb has 'Settings > > Add processing' (i.e. is missing 'Processings' between >) 4. Click on 'Edit this processing' => FAIL: Same error, different context 5. Check the browser console => FAIL: You see something like this: ``` [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" devtools-BLCumUwL.mjs:59:1 ``` 6. Run the cypress tests for this module: k$ run_cypress --spec t/cypress/integration/Preservation/Settings.ts => FAIL: The breadcrumb navigation is broken 7. Apply this patch 8. Rebuild things: $ ktd --shell k$ yarn build 9. Fully refresh the page (Use cmd+shift+r on macOS, ctrl+shift+r on Linux/Windows) 10. Repeat 2-6 => SUCCESS: The breadcrumb is no longer broken => SUCCESS: No errors/warnings about this in the browser console => SUCCESS: Tests pass! 11. Sign off :-D Signed-off-by: Tomás Cohen Arazi <[email protected]> Signed-off-by: Lucas Gass <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
