https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27834
--- Comment #28 from Marcel de Rooy <[email protected]> --- (In reply to Martin Renvoize (ashimema) from comment #27) Thx for your detailed explanation. > That said, if we think backwards compatibility should take precedence, we > could change this. I'd certainly at least mention the change in the release > notes. If we go this way, I would say that it must be changed. > The old behaviour had an unintended consequence: when a general rule > (branch=*) matched, it would fall back to counting ALL checkouts, even when > libraries wanted branch-specific limits. This is exactly the problem UAL > encountered with their laptop > loans. While thinking about this before, I concluded that the handling of the second rule ($branch_borrower_circ_rule) in TooMany is wrong. It should have the same global/branch scope as in handling the first rule. See also 41280 and earlier comments. In the UAL case this could probably solve their issue. Since they wanted PickupLibrary, a global $branch_borrower_circ_rule rule would count all checkouts instead of using a pickup library filter. > The new system provides consistent, predictable behaviour regardless of rule > specificity: [..] > This is explicitly documented in the commit message: "This applies > regardless of whether the matching circulation rule is branch-specific or > general (branch=*), ensuring consistent behaviour across all rule types." I am not sure if we are actually bending the concept of global and library circ rules here. We now make it possible to create a library rule that we can apply to all checkouts by setting this new pref. And vice versa, a global rule that we only apply on branch level. It feels more consistent to apply global rules only globally and branch rules only on branch level. See also 41280 about PatronLibrary; which is just inconsistent. > You're right that this creates 9 possible combinations. However, this was > actually at Nick's suggestion. @Nick: Could you clarify in this context why we need this flexibility? To me it feels like sacrificing consistency on circ rules. > Your questions about whether global-level rules should apply CircControl > filtering at all are interesting and touch on deeper architectural issues. I > agree that the interaction between branch-level and global rules can be > non-intuitive. > However, this patch was scoped to solve a specific problem: libraries need > control over checkout counting scope independent of which rules apply. The > broader questions you raise about rule hierarchy and global rule behaviour > might be better addressed in separate bugs (as you've started with 41280 and > 41290). I just fear that the current solution will not make things easier. Having the impression that addressing the current bugs/inconsistencies along the lines of 41280 will not bypass the idea behind our circulation rules. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
