https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from David Nind <[email protected]> --- I'm probably not the right person to test this one. If the results I got are what is expected, I'm happy to sign off. Testing notes (using KTD): 1. System prferences: - Enable HoldsLog - Enable RenewalLog - Enable AllowNotForLoanOverride - The IssueLog is already enabled 2. Items to use (all located in Centerville): - 39999000011111 - 39999000005776 - 39999000005134 - 39999000000498 - 39999000011418 3. Actions (before and after the patch) to see what is logged: - Check out an item to Mary Burton - Check out an item to Mary Burton, with the due date set before the current date - prompted to confirm - Place a hold for Mary Burton - Change an item for a record to Not for loan, attempt to issue, confirm override and check out - Renew an item 4. Before and after database and log viewer entries - SQL: select * from action_logs; Before ====== Database: | 17 | 2025-12-26 09:07:50 | 51 | CIRCULATION | ISSUE | 49 | { "branchcode" : "CPL", "confirmations" : [], "forced" : [], "issue" : 1, "itemnumber" : 563 } | intranet | NULL | NULL | NULL | | 18 | 2025-12-26 09:08:08 | 51 | CIRCULATION | ISSUE | 49 | { "branchcode" : "CPL", "confirmations" : [ "INVALID_DATE" ], "forced" : [], "issue" : 2, "itemnumber" : 296 } | intranet | NULL | NULL | NULL | | 19 | 2025-12-26 09:08:39 | 51 | HOLDS | CREATE | 1 | 1 | api | NULL | NULL | NULL | | 23 | 2025-12-26 09:28:52 | 51 | CIRCULATION | ISSUE | 49 | { "branchcode" : "CPL", "confirmations" : [ "NOT_FOR_LOAN_FORCING" ], "forced" : [], "issue" : 3, "itemnumber" : 32 } | intranet | NULL | NULL | NULL | | 24 | 2025-12-26 09:29:32 | 51 | CIRCULATION | RENEWAL | 49 | { "confirmations" : [], "forced" : [], "issue" : 2, "itemnumber" : "296" } | intranet | NULL | NULL | NULL | How they show in the log viewer: ... Circulation Checkout Mary Burton (49) Item 39999000011111 CPL Staff interface ... Circulation Checkout Mary Burton (49) Item 39999000005776 CPL Invalid date confirmed Staff interface ... Holds Create 1 1 REST API ... Circulation Checkout Mary Burton (49) Item 39999000000498 CPL Item was not for loan Staff interface ... Circulation Renew Mary Burton (49) Item 39999000005776 CPL Staff interface After ===== Database: | 27 | 2025-12-26 09:38:09 | 51 | CIRCULATION | ISSUE | 49 | { "branchcode" : "CPL", "confirmations" : [], "forced" : [], "issue" : 4, "itemnumber" : 578 } | intranet | NULL | NULL | NULL | | 31 | 2025-12-26 09:40:52 | 51 | CIRCULATION | ISSUE | 49 | { "branchcode" : "CPL", "confirmations" : [ "INVALID_DATE" ], "forced" : [], "issue" : 6, "itemnumber" : 264 } | intranet | NULL | NULL | NULL | | 29 | 2025-12-26 09:39:04 | 51 | HOLDS | CREATE | 2 | { "biblionumber" : "19", "branchcode" : "FPL", "confirmations" : [], "forced" : [], "hold" : 2, "itemnumber" : null } | intranet | NULL | NULL | NULL | | 28 | 2025-12-26 09:38:31 | 51 | CIRCULATION | ISSUE | 49 | { "branchcode" : "CPL", "confirmations" : [ "INVALID_DATE", "NOT_FOR_LOAN_FORCING" ], "forced" : [], "issue" : 5, "itemnumber" : 32 } | intranet | NULL | NULL | NULL | | 34 | 2025-12-26 09:41:09 | 51 | CIRCULATION | RENEWAL | 49 | { "confirmations" : [], "forced" : [], "issue" : 4, "itemnumber" : "578" } | intranet | NULL | NULL | NULL | How they show in the log viewer: ...Circulation Checkout Mary Burton (49) Item 39999000011418 CPL Staff interface ...Circulation Checkout Mary Burton (49) Item 39999000005134 CPL Invalid date confirmed Staff interface ...Holds Create 2 { "biblionumber" : "19", "branchcode" : "FPL", "confirmations" : [], "forced" : [], "hold" : 2, "itemnumber" : null } Staff interface ...Circulation Checkout Mary Burton (49) Item 39999000000498 CPL Invalid date confirmed Item was not for loan Staff interface ...Circulation Renew Mary Burton (49) Item 39999000005134 CPL Staff interface Tests (these pass) ===== prove t/db_dependent/Circulation.t prove t/db_dependent/Reserves.t Migration script ================ perl misc/maintenance/migrate_action_logs_to_json.pl --help perl misc/maintenance/migrate_action_logs_to_json.pl --verbose perl misc/maintenance/migrate_action_logs_to_json.pl --commit perl misc/maintenance/migrate_action_logs_to_json.pl -c Starting migration of action logs to JSON format... COMMIT MODE - Changes will be saved Found 0 CIRCULATION ISSUE log entries to migrate Found 1 HOLDS CREATE log entries to migrate Total: 1 entries Completed CIRCULATION ISSUE: 0 converted, 0 errors === Processing HOLDS CREATE logs === Processed 1000 / 1 records... Completed HOLDS CREATE: 1 converted, 0 errors === Migration Summary === CIRCULATION ISSUE: Converted: 0 Errors: 0 HOLDS CREATE: Converted: 1 Errors: 0 TOTAL: Converted: 1 Errors: 0 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
