https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237
Harrison Hawkins <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |[email protected] | |t.nz --- Comment #7 from Harrison Hawkins <[email protected]> --- (In reply to Marcel de Rooy from comment #5) > - <label for="page_side">Page side: > </label> > + <label for="page_side_front">Page > side: </label> > Not sure about this change. Why front here? > > + <label > for="page_side_front">Front: <input type="radio" name="page_side" > id="page_side_front" value="F" /></label> > Why include the input in the label ? > > Please explain. In response to your first comment we have changed the labels for page side, guide box, guide grid. In response to second comment about inputs in labels we have noticed this formatting is elsewhere in koha for example see below: koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt: <label><input type="radio" name="branch" value="homebranch" /> Home library</label> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
