https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40813
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <[email protected]> --- 1) QA checks - failing (blocker) I am not sure about the span error. I have tried to spot it, but failed. But will be interesting to check maybe. Processing files [RUNNING] C4/Auth.pm [RUNNING] koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc [ ] 0/2 tests completed [error] E3jaz8Qpz5.tt: SyntaxError: Unexpected closing tag "span". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags (4:9) [error] 2 | #~136~# [error] 3 | #~137~# [error] > 4 | </span> [error] | ^^^^^^^ [error] 5 | </div> [error] 6 | </footer> [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc [PASS] C4/Auth.pm Result: [PASS] C4/Auth.pm [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc FAIL filters missing_filter at line 301 ( <span class="navbar-text start_time" data-start="[% start_time %]">) missing_filter at line 303 ( [% start_time.hms(':') %]) missing_filter at line 306 ( <span class="navbar-text end_time" data-end="[% end_time %]">) missing_filter at line 308 ( [% end_time.hms(':') %]) FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc` Processing additional checks PASS! 2) Code review Nothing spotted. 3) Testing a) System preference / Debug setting (blocker) It works as described, but I agree with Lucas' comment about the preference. This should be optional and have a switch to turn on/off b) Styling (no blocker) Right now it doesn't stay at the bottom of the page but moves up on pages with not a lot of content. For testing it might be nicer to "pin" it to the bottom, so you can compare a little easier between pages, etc. because it's always in the same spot. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
