https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35617
--- Comment #8 from Katrin Fischer <[email protected]> --- 0) Conflict There was a minor conflict in identity_providers.tt that I resolved. 1) QA checks (minor) Some minor QA test fails (tidyness and file permission): Processing files [RUNNING] api/v1/swagger/definitions/identity_provider.yaml [RUNNING] installer/data/mysql/atomicupdate/extend_identity_providers.pl [RUNNING] installer/data/mysql/kohastructure.sql [RUNNING] koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt [PASS] api/v1/swagger/definitions/identity_provider.yaml [FAIL] installer/data/mysql/atomicupdate/extend_identity_providers.pl [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt [PASS] installer/data/mysql/kohastructure.sql Result: [PASS] api/v1/swagger/definitions/identity_provider.yaml [FAIL] installer/data/mysql/atomicupdate/extend_identity_providers.pl FAIL file_permissions File must have the exec flag FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl installer/data/mysql/atomicupdate/extend_identity_providers.pl` [PASS] installer/data/mysql/kohastructure.sql [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt -> Fixed these in a follow-up. Also included say_success and removed some unneeded comments from database update. 2) Code review (minor) Nothing else spotted. 3) Testing - updatedatabase - dbic - yarn build - restart_all Verified that the matchpoint phone can be configured, saves correctly and can be edited. This all works as expected. I didn't verify that the matchpoint actually works, but I believe it's enough for a SO at this point. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
