https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134
Paul Derscheid <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191954|0 |1 is obsolete| | --- Comment #23 from Paul Derscheid <[email protected]> --- Created attachment 192796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192796&action=edit Bug 40134: Implement optimal item selection for 'any item' bookings This patch implements an algorithm for selecting the item that would leave the largest gap after the proposed booking to maximize the opportunity for future bookings. Key Changes: Koha::Booking: - Added set_itemtype_filter() method for transient itemtype parameter - Added _select_optimal_item() method using single aggregated query * Groups bookings by item_id with MIN(start_date) * Selects items with no future bookings (optimal) * Among items with bookings, selects one with latest next booking * O(1) complexity - single database query with GROUP BY - Updated _assign_item_for_booking() to use optimal selection * Filters by itemtype when itemtype_id is provided * Replaces previous random selection (RAND()) API Changes: - Added itemtype_id parameter support to add() endpoint - Added itemtype_id parameter support to update() endpoint - Validates exactly one of item_id or itemtype_id is provided - itemtype_id is transient - not persisted to database - Extracted and applied via set_itemtype_filter() before store() Architecture: - itemtype_id is NOT a database column (transient only) - Used as selection criterion, then discarded Test plan: 1. Apply patch and restart services 2. Create "any item" booking via staff interface 3. Verify item with longest future availability is selected 4. Test via API with itemtype_id parameter 5. Verify itemtype_id is not persisted to database 6. Run t/db_dependent/Koha/Booking.t 7. Run t/db_dependent/api/v1/bookings.t Signed-off-by: Kristi Krueger <[email protected]> Signed-off-by: Paul Derscheid <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
