https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415
--- Comment #234 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 193088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193088&action=edit Bug 23415: Fix FineNoRenewals to use non_issues_charges and improve template This commit addresses two issues: 1. Fixes FineNoRenewals logic to properly use non_issues_charges Both CanBookBeRenewed() and _CanBookBeAutoRenewed() were incorrectly using the patron's total balance when checking against FineNoRenewals. They now use non_issues_charges, which returns only charges that should restrict checkouts (e.g., overdues, lost items) as defined by debit types with restricts_checkouts=1. This ensures charges like rental fees don't inappropriately block renewals. 2. Improves renewal template for AllowFineOverrideRenewing - Adds special handling for auto_too_much_owing error to check AllowFineOverrideRenewing preference instead of AllowRenewalLimitOverride - Adds missing id="barcode" attribute to input field for Cypress tests - Adds .dialog CSS class to error/success divs for consistent styling - Fixes HTML structure with proper <ul><li> wrapping - Adds btn btn-default classes to override button 3. Fixes Cypress test issues - Corrects data structure access: items[0] instead of item - Uses external_id instead of barcode (API field name) - Improves form submission selector specificity - Uses REPLACE INTO for system preference setup Test plan: 1. Run t/cypress/integration/Circulation/FineNoRenewals_spec.ts 2. Verify 4 out of 5 tests pass (one remaining template comparison issue) 3. Manually test that patrons with non-issue charges (rental fees) can renew when those charges alone don't exceed FineNoRenewals 4. Verify that patrons with issue-blocking charges (overdues) are properly blocked from renewal when exceeding FineNoRenewals Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Andrew Fuerste Henry <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
