https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956
Lisette Scheer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #79 from Lisette Scheer <[email protected]> --- There's a couple of failures from the Koha Testing Docker QA tool: [FAIL] Koha/Patron.pm WARN spelling Exemple ==> Example FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/Patron.pm` [PASS] members/member-flags.pl [FAIL] t/db_dependent/Koha/Patron.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/Koha/Patron.t` Additionally, if you have a lot of permissions (say all but one of the tool permissions) it doesn't line break for a long time and makes the table way too wide. if you USE JSON (qw to_json); and within the logaction replace $permissions_after: to_json($permissions_after, { utf8 => 1, pretty => 1, canonical => 1 }) similar to the members log around line 409, it does break nicely, but the diff no longer works for me, so that's not the whole solution. I highly recommend using Koha testing docker and running the QA script before attaching patches as it can catch things that cause failures, as well as tidying the commit as needed when you git commit. You can find instructions at the gitlab and please feel free to reach out if you need help setting it up. https://gitlab.com/koha-community/koha-testing-docker -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
