https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41944
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193981|0 |1 is obsolete| | --- Comment #2 from David Nind <[email protected]> --- Created attachment 194201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194201&action=edit Bug 41944: Fix template error for non-existent ILL requests This patch fixes a template error that occurred when attempting to view a non-existent ILL request in the staff interface. Previously, navigating to ill-requests.pl with an invalid illrequest_id would result in a 500 error and a stacktrace. This change introduces a check for the existence of the ILL request immediately after retrieval. If no request is found, the script now redirects to the standard 404 error page, providing a graceful exit and preventing internal errors. Test plan: 1. Ensure KTD is launched with Rapido ILL plugin and bootstrapped (do NOT apply this patch yet): $ ktd --proxy --name rapido --single-plugin ~/git/koha-plugins/rapido-ill up -d $ ktd --shell k$ cd /kohadevbox/plugins/rapido-ill/scripts k$ perl bootstrap_rapido_testing.pl k$ restart_all 2. Log into the staff interface at http://rapido-intra.localhost. 3. Point your browser to a non-existent ILL request, e.g., http://rapido-intra.localhost/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1000 => FAIL: Template errors and a stacktrace are displayed, or a 500 error in production logs. 4. Apply this patch. 5. Repeat step 3. => SUCCESS: The browser redirects to a 404 Not Found page, and no template errors or stacktraces are displayed. 6. Sign off :-D Signed-off-by: David Nind <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
