https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365
--- Comment #273 from David Cook <[email protected]> --- (In reply to David Cook from comment #271) > (In reply to Jonathan Druart from comment #265) > > (In reply to David Cook from comment #258) > > > (In reply to Jonathan Druart from comment #253) > > > > Ok, however I found more: > > > > Caught by the xt tests (and now by add_csp_nonces.pl as well) > > > > * t/lib/plugins/Koha/Plugin/TestValuebuilder/test_valuebuilder_popup.tt > > > > > > So this is an interesting one. I will upload a patch for this one, but > > > it's > > > going to work differently to what you might expect. I'll explain more in > > > my > > > response to your comment about cataloguing plugins. > > > > > > (To test this one, you'll want to run `prove > > > t/db_dependent/Koha/Plugins/Valuebuilder_hooks.t`) > > > > xt/find-missing-nonce.t is still failing on this file then. Should we > > exclude it? > > I think that we should exclude it, since it's good at testing that > Koha::FrameworkPlugin is working correctly at this time. Hmm... I looked at adding an exclusion but not sure how we do it. If we change Koha::Devel::Files->ls_tt_files to exclude that test template, won't we be excluding it from other scripts perhaps should include it? It would be good to be able to provide runtime exceptions to ls_tt_files() and friends. What do you think, Jonathan? (It wouldn't be the end of the world if we did add a nonce to test_valuebuilder_popup.tt, but it probably is good to also be able to provide future exceptions anyway.) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
