https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956
--- Comment #90 from David Nind <[email protected]> --- Created attachment 194612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194612&action=edit Log viewer results - after patch Sorry, I'm not seeing the diff as shown in the screenshot on bug 36698. Screenshot attached showing what I see in the log viewer. I have applied the patch, run yarn build, restarted everything, and cleared the browser cache. I even shutdown KTD and restarted with the patch applied in case it was a build thing. Testing notes (using KTD): 1. Go to a staff interface. 2. Search for a patron and change their permissions (note their borrower number) (for example: Henry Acevedo (23529000035676), borrower number 19, add and remove "Access to all librarian functions (superlibrarian)" 3. Go to Tools > Additional tools > Log viewer. 4. Filter the log entries as follows: - Module = Patrons - Object = <borrowernumber> (for example, 19) 5. Click on submit: ==> There are no log entries for permission changes 6. Apply the patch, rebuild everything (yarn build), restart everything (restart_all), and clear your browser cache. 7. Repeat steps 1 to 5: ==> Permission changes are now logged [1] 8. Check that the diff column in the database contains the full details of the changes: [2] select diff from action_logs where object= <borrowernumber> order by action_id desc limit 1; 9. The tests pass: 9.1 prove t/db_dependent/Koha/Patron.t 9.2 prove t/db_dependent/Log.t [1] Log viewer information: See the screenshot: Modify Henry Acevedo (19) {} Modify Henry Acevedo (19) { "superlibrarian" : 1 } [2] select diff from action_logs where object=19; +----------------------------------+ | diff | +----------------------------------+ | {"D":{"superlibrarian":{"A":1}}} | | {"D":{"superlibrarian":{"R":1}}} | +----------------------------------+ -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
