http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682
Chris Cormack <ch...@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20614|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <ch...@bigballofwax.co.nz> --- Created attachment 20646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20646&action=edit Bug 10682 : Inappropriate uses of finish() in C4::Reserves This patch gets rid of finish. >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkrie...@gmail.com> Comment: Similar to other patches from the same author I run prove t/db_dependent/Reserves.t without errors don't know if more tests are needed. No koha-qa errors Signed-off-by: Chris Cormack <chr...@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/