http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897

--- Comment #30 from Jared Camins-Esakov <jcam...@cpbibliography.com> ---
Additionally, it looks like there are no unit tests. Is it possible to unit
test C4::GnuPG?

Finally, and this is a definite blocker, it looks like C4::GnuPG is initialized
with file-level my variables:

+my $gpg = new Crypt::GPG;
+$gpg->gpgbin('/usr/bin/gpg');
+$gpg->encryptsafe(0); # we have to allow untrusted keys

This will not work well with persistent environments like Plack. The my could
be changed to our, but even better would be changing the way initialization is
handled such that a file-level variable is unnecessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to