https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973
--- Comment #4 from Owen Leonard <[email protected]> --- Created attachment 198628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198628&action=edit Bug 34973: Upgrade Font Awesome in the OPAC to 7.2 We are using Font Awesome 6.3 in the OPAC. The current version is 7.2. Upgrading will eliminate the repeated warnings in the browser console about "Glyph bbox was incorrect." The patch adds Font Awesome to the list of packages in node_modules and moves the Font Awesome SCSS into _common.scss so that it can be bundled along with Bootstrap and other 3rd party assets. Despite the fact that _common.scss grabs FA SCSS files directly from node_modules I've added the FA font files to css/fonts. I was unable to see how to reference the webfonts directory in node_modules/@fortawesome. The many changed .inc and .tt files are a result of a missed aspect of our upgrade to Bootstrap 5. The "sr-only" class was removed in BS5 but the Font Awesome CSS included its own "sr-only" class. This made up for the fact that we missed the required upgrade to BS5's "visually-hidden." As soon as Font Awesome's "sr-only" was gone all these mistakes were made visible. To test, apply the patch and run 'yarn install.' - Rebuild the OPAC SCSS. - Clear your browser cache. - Test many pages in the OPAC to confirm that no icons are missing. - Check changes to the templates to confirm that "sr-only" has been replaced with "visually-hidden." - Places where a broken "sr-only" class would be obvious: Star ratings on the user summary page, <legend>s on the search history page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
