https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42386

--- Comment #7 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Created attachment 198832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198832&action=edit
Bug 42386: Wire CanBookBeReserved to use Koha::Biblio::Availability::Hold

CanBookBeReserved is now a thin wrapper around
Koha::Biblio::Availability::Hold->check.

Behavior changes:
- Returns 'no_items' instead of '' when biblio has no items
- Returns 'no_item_available' instead of last item's blocker when all
  items are blocked
- Returns 'too_many_reserves' instead of '' when itemtype limit reached

These are more descriptive statuses. All callers check eq 'OK' so
non-OK values are equivalent.

Assisted-by: Sonnet 4.6 (Anthropic)

Test plan:
1. Apply patch
2. Run:
   $ ktd --shell
   k$ prove t/db_dependent/Reserves.t \
          t/db_dependent/Holds.t \
          t/db_dependent/Koha/Biblio/Availability/Hold.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to