https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29016
--- Comment #51 from Kyle M Hall (khall) <[email protected]> --- Created attachment 198852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198852&action=edit Bug 29016 [25.11.x]: (QA follow-up) Translate circulation overrides in info column CIRCULATION rows whose info payload is a JSON object can carry `forced` and `confirmations` arrays listing the override codes a librarian acknowledged when checking out, renewing or otherwise circulating an item (e.g. DEBT, AGE_RESTRICTION, BIBLIO_ALREADY_ISSUED). The old server-rendered template ran these through the translate_log_override SWITCH block in action-logs.inc; in the new AJAX-driven viewer the JS default branch was just escapeHtml()-ing the raw JSON, leaving the codes unlocalised and unreadable. Port the override -> human-readable label map into str/viewlog.inc as override_labels, mirroring the module/action/interface label maps already there. Add a renderCircInfo() helper that recognises the JSON shape and emits the same div.forced / div.confirmed blocks the old template did, so the existing CSS continues to apply. renderInfo() now falls through CIRCULATION -> renderCircInfo, the generic record-info renderer (CATALOGUING / AUTHORITIES from bug 42032) and finally escapeHtml(), so non-JSON payloads (item barcodes, ID-only info, ...) keep displaying as before. Test plan: 1. Enable IssueLog. 2. Trigger an override checkout (e.g. patron with debt, item not for loan) and confirm. 3. Tools -> Log viewer, filter by module=Circulation. 4. The override row's Info column should show one or more localised "Patron had debt", "Item was not for loan", ... lines instead of a raw JSON blob. 5. Plain ISSUE / RETURN rows (no overrides) keep showing the raw itemnumber / barcode payload as before. Signed-off-by: Lucas Gass <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
