https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35142

--- Comment #2 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Created attachment 198873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198873&action=edit
Bug 35142: Remove GetNormalizedOCLCNumber and oclc_number

Unifies OCLC number extraction into the MetadataExtractor pattern.
The get_normalized_oclc method now lives in the base ::MARC class
(035$a is flavor-independent) with improved matching:

- Case-insensitive OCoLC detection (matches ocolc, OCOLC, etc.)
- Generic orgcode prefix stripping (any parenthesized prefix, not
  just literal "(OCoLC)") for resilience against cataloging typos

This resolves a pre-existing inconsistency where different code paths
produced different results for the same record depending on which
implementation was used.

Assisted-by: Sonnet 4.6 (Anthropic)

Test plan:
1. Apply patch
2. Run:
   $ ktd --shell
   k$ prove t/Koha/Util/MARC.t \
          t/db_dependent/Koha.t \
          t/db_dependent/Koha/Biblio.t \
          t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/MARC21.t
=> SUCCESS: Tests pass
3. Verify OCLC numbers still display in OPAC and staff detail pages
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to