https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729
David Cook <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from David Cook <[email protected]> --- After reviewing the code in C4::Koha and Business::ISBN, I think the patch is good but I think we need to update the unit tests in t/db_dependent/Koha.t for this one. Looks like GetNormalizedISBN, which uses _isbn_cleanup, is used in quite a few places, so might be necessary to check out some other unit tests too. This actually looks like it'll have fairly widespread repercussions. In theory, it should be a good move across the board, but... wise to check it out more thoroughly I think. -- To avoid unintended consequences, it might not be a bad idea to scope this change more narrowly. Instead of using "normalized_isbn" in places like opac-detail.tt, it could be a good idea to use something like "isbn_for_coverimage". Sometimes in Koha we end up making what looks like a sensible change but we don't take into account the wide-reaching effects. Again, I can't see the harm... but there's a lot of places that use GetNormalizedISBN so unless we check them all right now... I think maybe best to scope this one more narrowly. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
