https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40901
--- Comment #73 from Kyle M Hall (khall) <[email protected]> --- Created attachment 199092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199092&action=edit Bug 40901: (follow-up) Fail loudly when koha-sip is enabled without flag file The [email protected] unit gates startup on /var/lib/koha/<inst>/sip.enabled, the per-instance "I want SIP on" flag file. `koha-sip --enable` creates that flag in the same call that runs `systemctl enable`; running a bare `systemctl enable koha-sip@<inst>.service` only flips the systemd half, so the unit ends up enabled-but-refusing-to-start. With ConditionPathExists the failure mode is silent and the unit ends up "enabled" at the systemd level but "Active: inactive" (dead) with "Condition: start condition failed" and the journal logs aren't a big help figuring out the problem. This patch replaces the silent skip with a loud failure with a helpful message: ERROR: SIP not enabled for instance <inst>. Use: koha-sip --enable <inst> SIPconfig.xml is gated by AssertPathExists if it's missing the unit fails. Either failure path lands the unit in failed state, surfaced by 'systemctl --failed' Signed-off-by: Kyle M Hall <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
