https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #20 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 199843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199843&action=edit Bug 36369: Introduce KohaApiClient base class Introduce KohaApiClient as the base class for all API clients. This class centralizes: - HttpClient instantiation with a base URL - The embed parameter: callers declare embeds as an array, and _resolveEmbed() translates it to the x-koha-embed HTTP header All 26 API client classes now extend KohaApiClient instead of receiving HttpClient as a constructor argument. All hardcoded x-koha-embed headers in client methods are replaced with the declarative embed: [...] parameter. The api-client.js orchestrators (vanilla JS and Vue) no longer import or pass HttpClient - they simply instantiate clients with no arguments. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ qa -c 1 => SUCCESS: QA passes 3. Verify ERM, preservation, SIP2, ILL, acquisitions, checkout modules still function (embeds correctly sent) 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
