https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42782
Bug ID: 42782
Summary: bulkmarkimport does not increment correctly
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Bug 37020 comment 74 Jonathan Druart
record_number is still incremented twice, is this because of a conflict fix
problem?
Bug 37020 comment 74 Jonathan Druart
Current version in main:
329 RECORD: while () {
330
331 my $record;
332 $record_number++;
333
334 # get record
335 eval { $record = $batch->next() };
336 if ($@) {
337 print "Bad MARC record $record_number: $@ skipped\n";
338
339 # FIXME - because MARC::Batch->next() combines grabbing the next
340 # blob and parsing it into one operation, a correctable condition
341 # such as a MARC-8 record claiming that it's UTF-8 can't be
recovered
342 # from because we don't have access to the original blob. Note
343 # that the staging import can deal with this condition (via
344 # C4::Charset::MarcToUTF8Record) because it doesn't use
MARC::Batch.
345 next;
346 }
347 if ($record) {
348 $record_number++;
349
This is wrong.
bug 37020 comment 75 Alexander Wagner
If I get the code right, the number of records ingested is still doubled. AFAIS
`$record_number++;` is called twice within the loop. Jan mentioned that he
ingested 1 record and got notified about 3, I also obeserved a result of 5
while I had only two (valid) records in the import file. Might be a minor issue
compared to all the rest but can be quite confusing if your catalogue migration
turns out to hold way more records that you expected. (Koha 25.05.00 ga)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
