https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42844
--- Comment #3 from Jonathan Druart <[email protected]> --- Created attachment 200448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200448&action=edit Bug 42844: Fix broken subscription search when using additional fields as seach criteria This fixes an error when searching for a subscription with an additional field when no result is found by changing the call of SearchSubscriptions to expect an array instead of an hash ref. Serials.pm, when using filter_by_additional_fields may return an empty array, but the calling function only checked for an hash ref which lead to an error when no result was found. Testplan: a) create an additional field for subscriptions: More -> Serials -> Manage subscription fields f.e. use an AV CCODE as additional field make sure "searchable" is checked No subscription should use this additional field by now. b) go to More -> Serials c1) if bug 40201 is pushed you can search for that additional field on serials-home -> An error stack trace will appear. c2) otherwise perform an empty search on serials home to end on serials-search. In the search form on the left select that additional field as search criteria. -> An error stack trace will appear. d) add a subscription using that additional field -> More -> Serials -> New subscription. On step two there is a section for Additional fields. Select f.e. CCODE Fiction e) redo c1 or c2 using that additonal field value as search criteria. f) Check that the search result shows your subscription. g) apply patch and redo c1 or c2 for an additional field value that is not used (f.e. Non-fiction) h) The search should work now, returning 0 results instead of an error i) check that searching for a used additional field (f.e. Fiction) still works Signed-off-by: Michaela Sieber <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
