https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32453
--- Comment #7 from Kyle M Hall (khall) <[email protected]> --- (In reply to David Cook from comment #6) > (In reply to Marcel de Rooy from comment #4) > > Not sure if we should go this way and put such constructs in our templates > > too. > > This needs a broader dev discussion. > > Please trigger it by mailing dev list or putting it on dev meeting agenda. > > Yeah, I don't think this change makes sense. I'm sure there are times it > would be useful to access private methods, but that should probably signal > that we have some missing functionality. > > Are there any particular use cases in mind for this one? The idea is to not populate our classes with functions used solely for the purpose of data being accessible from notice templates. A small handful of generic accessors would be better then a multitude of specific ones that we'd need to maintain without knowing if they are even being used. I'll try to find some specific use cases. It's worth noting now that template renders are wrapped in a rolled back transaction. An alternative would be to add public result and resultset accessors specifically instead of enabling access to all private accessors. Would that be a better solution? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
