https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42444
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Jonathan Druart <[email protected]> --- 1. Not blocker but I would have expected the tab content to be loaded on demand. 2. "Cancel all" cancels everything, without confirmation Also note that "Cancel hold" (in the "Actions" column) does not trigger a confirmation, but "Cancel selected" does (asking for a reason) 3. We usually use escape_str instead of escapeHtml, because it takes care of null values. return (data || "").escapeHtml(); Note that here you also remove "0", when escape_str deals with it correctly. Also note that there are variables not escaped in the last column ("Actions") 4. Instead of: ``` let cols = [{ stuff }]; if (condition) { cols.push({other_stuff}); } cols.push({yet_another_stuff}); ``` I would suggest: let cols = [ {stuff}, ...(condition ? [{other_stuff}] : []} {yet_anot_erstuff}, ]; Of course not blocker, but I have used it extensively in the different patches still in the queue (42278, 42332, etc.) 5. data: "patron.surname", Then search on firstname does not work 6. Search on library names in the global search does not work. (search for coded_values and filters_options in includes/html_helpers/tables/items/catalogue_detail.inc or includes/patron-search.inc for examples). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
