https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033
--- Comment #1 from Olivia Reynolds <[email protected]> --- Created attachment 200909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200909&action=edit Bug 42033: Add action log diffs for restrictions and messages This patch ensures that the diffs for patron restrictions and messages appear in the action log. It widens logaction's detection of create/delete actions, and passes the original version of the respective models in for diffing. Test plan: 1. In one tab, open Tools > Log Viewer, and click "Submit" to load a complete list of log entries. 2. Enable the "Diff" column for log entries. 3. In another tab, navigate to a patron's circulation page (you can click their barcode from patron search). 4. Click "Add message", and enter any message for the patron. 5. On the patron page, find the message, and edit the text to something different. 6. On the patron page, find the message, and delete it. 7. Refresh the log results page. 8. Verify there are three log entries for creating, editing, and deleting the message. Each should include a diff. 9. On the patron page, click the "Restrictions" tab near the bottom, and add a manual restriction with any text. 10. On the patron page, click the "Restrictions" tab near the bottom, and delete the manual restriction you just added. 11. Refresh the log results page. 12. Verify there is a log entry for both creating and deleting the restriction, each including a diff. 13. Under Administration > Circulation and fine rules, ensure "Suspension in days" is set to a non-zero value. 14. On the patron page, check out an item to the patron, setting the due date to around a year ago. You'll need to confirm this due date. 15. Check the item back in. Verify the patron is suspended as a result. 16. Bypass the suspension restriction and check out an item to the patron, setting the due date to around _two_ years ago. 17. Check the item back in. Verify the patron's suspension has increased. 18. Refresh the log results page. 19. Verify there are two log entries for the creation and updating of the suspension restriction. Each should have a displayed diff. Sponsored-by: Open Fifth -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
