https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42189
--- Comment #58 from Paul Derscheid <[email protected]> --- Created attachment 201077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201077&action=edit Bug 42189: (QA follow-up) Derive widget module id from dashboard name - ModuleDashboard gained a required "module" prop in this patch set to filter plugin widgets, but bug 37762 had since added a "name" prop (the localStorage key, e.g. "ERM"/"ILL"), making "module" redundant - Drop the "module" prop; derive the filter id from name.toLowerCase() ("ERM" -> "erm"), so callers pass a single prop - ERM/Home.vue no longer passes module="erm"; ILL/Home.vue, which only ever passed name="ILL", no longer trips the now-removed required-prop check and filters widgets correctly - Plugin contract is unchanged: widgets still register with a lowercase module id (e.g. module: "erm"); document that it must match the target dashboard's name lowercased To test: - yarn js:build - Install test-widgetdemo plugin, navigate to ERM home - Verify the plugin widget appears and is reactive - Verify no Vue warnings about a missing "module" prop on ILL home -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
