https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37502
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |ERM tab to the record | |details page in the staff | |interface. It lists the ERM | |packages that this title is | |associated with, and | |includes a link to the | |agreement and shows license | |details. --- Comment #20 from David Nind <[email protected]> --- I've signed off, but please note these two things: 1. The qa script complains about tidiness for some files [1] 2. If I add a title to other packages, the number shown in the ERM tab title still remains the same (see new screenshot added). I created bug 42933 (exists before this patch) - you can't add a license to an agreement. Testing notes (using KTD): 1. Apply the patch. 2. Rebuild everything: yarn build 3. Restart everything: restart_all [1] qa script errors - tidiness =============================== qa Tag v25.05.00-1 found in /kohadevbox/koha — checking out branch main in /kohadevbox/qa-test-tools Already on 'main' Your branch is up to date with 'origin/main'. testing 1 commit(s) (applied to fa92634 '32 Bug 42281: Tidy all script tags - ') Processing files [RUNNING] Koha/REST/V1/Biblios/ERMHoldings.pm [RUNNING] api/v1/swagger/paths/biblios_erm_holdings.yaml [RUNNING] api/v1/swagger/swagger.yaml [RUNNING] catalogue/detail.pl [RUNNING] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt [RUNNING] koha-tmpl/intranet-tmpl/prog/js/vue/components/Islands/ERMCatalogueTab.vue ] 0/7 tests completed [RUNNING] koha-tmpl/intranet-tmpl/prog/js/vue/modules/islands.ts [PASS] api/v1/swagger/paths/biblios_erm_holdings.yaml [PASS] api/v1/swagger/swagger.yaml [FAIL] koha-tmpl/intranet-tmpl/prog/js/vue/components/Islands/ERMCatalogueTab.vue============== ] 2/7 tests completed [PASS] koha-tmpl/intranet-tmpl/prog/js/vue/modules/islands.ts [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt [FAIL] catalogue/detail.pl [FAIL] Koha/REST/V1/Biblios/ERMHoldings.pm Result: [FAIL] Koha/REST/V1/Biblios/ERMHoldings.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/REST/V1/Biblios/ERMHoldings.pm` [PASS] api/v1/swagger/paths/biblios_erm_holdings.yaml [PASS] api/v1/swagger/swagger.yaml [FAIL] catalogue/detail.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl catalogue/detail.pl` [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt` [FAIL] koha-tmpl/intranet-tmpl/prog/js/vue/components/Islands/ERMCatalogueTab.vue FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/vue/components/Islands/ERMCatalogueTab.vue` [PASS] koha-tmpl/intranet-tmpl/prog/js/vue/modules/islands.ts Processing additional checks PASS! * Was this bug sponsored by anyone? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
