https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42933

David Nind <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes an issue for the
      release notes|                            |ERM module when adding a
                   |                            |license to an agreement.
                   |                            |The status field for the
                   |                            |license was not shown as
                   |                            |required. This generated an
                   |                            |error message if you
                   |                            |attempted to add a license
                   |                            |without selecting a value
                   |                            |for the status field:
                   |                            |"Something went wrong:
                   |                            |Error: Expected string -
                   |                            |got null.". The status
                   |                            |field is now marked as
                   |                            |required.
                   |                            |
                   |                            |(Related to Bug 38201 -
                   |                            |VueJS architecture rethink,
                   |                            |added to Koha 25.11.)

--- Comment #7 from David Nind <[email protected]> ---
Thanks Jonathan!

Testing notes (using KTD):
1. Enable the ERM module: set the ERMModule system preference to 'Enable'.
2. Got to the ERM module.
3. Add a license: Licenses > New license
   - Complete the mandatory fields
   - Click 'Save'
4. Add a test agreement: Agreements > New agreement
   - Completed the required fields
   - Under the licenses section, click 'Add new license'
   - Select the license you created from the dropdown list for the
     'Licenses' field 
   - Don't add data for any another fields for the license - none are marked 
     as mandatory
   - Click 'Save'
   - Get error with yellow background at the top of the page:
       "Something went wrong: Error: Expected string - got null."
   - Select a value for the status field, for example "Controlling"
   - Click 'Save'
   - The agreement is now created.
5. Apply the patches.
6. Rebuild everything: yarn build
7. Restart everything: restart_all
8. Repeat step 4 for a new agreement - the license status field is now
   marked as required. If you attempt to save the agreement without selecting
   a value, you are prompted to complete the required field.
9. Run the tests - these should pass: 
   cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to