https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42235

David Nind <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This fixes an accessibility |This fixes two
      release notes|issue with the patron's     |accessibility issues with
                   |OPAC messaging table (OPAC  |the patron's OPAC messaging
                   |> [log in] > Your account > |table (OPAC > [log in] >
                   |Messaging): "Table header   |Your account > Messaging):
                   |text should not be empty".
 |"Table header text should
                   |
                           |not be empty".
                   |Previously when responsive  |
                   |table controls were shown   |Previously:
                   |for the table (a green "+"  |1. The first column header
                   |button is shown when the    |has no text.
                   |browser window is narrower  |2. When responsive table
                   |and all the columns can't   |controls were shown for the
                   |be displayed), there was no |table, there was no title
                   |title for the column header |in the last column header
                   |with the controls.
         |with the controls (a green
                   |
                           |"+" button is shown when
                   |Now, the column header has  |the browser window is
                   |the text "Expand" when the  |narrower and all the
                   |responsive controls are     |columns can't be
                   |shown.                      |displayed).
                   |                            |
                   |                            |Now:
                   |                            |1. The first column header
                   |                            |now has the text "Message
                   |                            |type".
                   |                            |2. The responsive table
                   |                            |control column header has
                   |                            |the text "Expand" when the
                   |                            |responsive controls are
                   |                            |shown.

--- Comment #10 from David Nind <[email protected]> ---
Updated testing notes (using KTD):

First patch - Responsible table control column
----------------------------------------------

1. So that the responsive table controls are shown (a green button with +), set
SMSSendDriver to Email. The OPAC Messaging table now has an SMS column. When
you narrow the browser screen width, the responsive table controls are now
shown.

2. Before the patch, inspecting the HTML source:

...
<th class="dtr-control-col dtr-control dt-orderable-none" data-dt-column="5"
rowspan="1" colspan="1" style="">
<div class="dt-column-header">
  <span class="dt-column-title"></span>
  <span class="dt-column-order"></span>
</div>
</th>
...

3. Before the patch, using axe DevTools, there is one issue (when on a narrower
browser window size with the responsive table control visible) for "Table
header text should not be empty".

4. After the patch, inspecting the HTML source:

...
<th class="dtr-control-col dtr-control dt-orderable-none" data-dt-column="5"
rowspan="1" colspan="1" style="">
<div class="dt-column-header">
  <span class="dt-column-title">Expand</span>
  <span class="dt-column-order"></span>
</div>
</th>
...

5. Has "Expand" as the column title.

Second patch - First column header
----------------------------------

6. Before the patch, inspecting the HTML source:

...
<div class="dt-column-header">
  <span class="dt-column-title">&nbsp;</span>
  <span class="dt-column-order" role="button" aria-label="&nbsp;: Activate to
invert sorting" tabindex="0"></span>
</div>
...

7. axe DevTools didn't identify any issues (showing that automated tools don't
always pick up everything!).

8. After the patch:

<div class="dt-column-header">
  <span class="dt-column-title">Message type</span>
  <span class="dt-column-order" role="button" aria-label="Message type:
Activate to invert sorting" tabindex="0"></span>
</div>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to