https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42505
Lucas Gass (lukeg) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] --- Comment #4 from Lucas Gass (lukeg) <[email protected]> --- (In reply to Martin Renvoize (ashimema) from comment #3) > Created attachment 199178 [details] [review] > Bug 42505: Open hold transfer slip in user gesture to bypass popup blocker > > When returning an item required to fulfil a hold at another branch with > HoldsAutoFill set to "Don't", the librarian is shown a "Hold found" > modal and chooses "Print slip, transfer, and confirm". The previous > implementation set a hidden 'print_slip' input to 1, submitted the > form, and relied on $(document).ready on the response page to call > Dopop() / window.open() to open the slip. Because that window.open() > is no longer associated with a user gesture (the gesture chain is > broken by the form submission and page navigation), modern browsers > block it as an unsolicited popup. The hold is confirmed but the slip > never appears, and the librarian may not realise it was attempted. > > This patch opens the slip synchronously inside the .print click > handler instead, while the user gesture is still active, so the > browser allows the window.open() through. The form is then submitted > as before to confirm the hold. The reserve_id is taken from the > hidden input already present in the modal form; hold-transfer-slip.pl > needs only the reserve_id and does not require the hold to have been > moved to "Waiting" state first, so the slip content is correct. > > To test: > 1. Set syspref HoldsAutoFill = "Don't". > 2. Place a hold for a patron whose pickup branch is different from > your logged-in branch. > 3. Check in the item at your logged-in branch. > 4. The "Hold found" modal appears. > 5. Click "Print slip, transfer, and confirm". > 6. Confirm the hold transfer slip opens in a new window and is not > blocked by the browser's popup blocker. > 7. Confirm the hold is still correctly confirmed and the item placed > in transit. > 8. Repeat with HoldsAutoFill = "Don't" and a same-branch hold, > clicking "Print slip and confirm" instead, and confirm the slip > opens for that path too. > > Sponsored-by: OpenFifth <https://openfifth.co.uk/> > Signed-off-by: Jackie Usher <[email protected]> In step 1 the test plan is set HoldsAutoFill = "Don't". In step 8 it is Repeat with HoldsAutoFill = "Don't". Can you clarify the test plan here? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
