https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart <[email protected]> --- (In reply to Brendan Lawlor from comment #12) > (In reply to Andrew Fuerste-Henry from comment #11) > > (In reply to Brendan Lawlor from comment #10) > > > > > 7. Set system preference HidePatronName to 'Don't show' > > > 8. Confirm searching by patron names continues to work :) > > > > I don't think this is the behavior we want. > > Thanks for testing and clarification on the expected behavior. > > I fixed this by conditionally setting data like this: > data: HidePatronName > ? "patron.cardnumber" > : "patron.surname:patron.firstname:patron.cardnumber", > > I'm having trouble attaching the patch to bugzilla right now, but I will try > again later This is not correct. If it's considered a privacy issue (what it is) we should not deal with the restriction in client-side. Tomas dealt with that on bug 42503. I am not sure we should deal with that on this bug. I would remove the JS test and fix the endpoint on a separate bug. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
