https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
--- Comment #218 from Jonathan Druart <[email protected]> --- Quick review: 1. This does not seem correct: opac/opac-recall.pl -if ( C4::Context->preference('UseRecalls') ) { +if ( $op eq 'cud-cancel' ) { + my $recall_id = $query->param('recall_id'); + Koha::Recalls->find($recall_id)->set_cancelled; + print $query->redirect('/cgi-bin/koha/opac-user.pl'); +} + +if ( C4::Context->preference('UseRecalls') =~ m/opac/ ) { We should reach cud-cancel only if UseRecalls is set. 2. recalls/request.pl + single_branch_mode => $single_branch_mode, not needed, C4::Auth already pass singleBranchMode 3. + attribute_type_codes => ( + C4::Context->preference('ExtendedPatronAttributes') + ? [ Koha::Patron::Attribute::Types->search( { staff_searchable => 1 } )->get_column('code') ] + : [] + ), not used in the template? 4. +my $items = Koha::Items->search( { biblionumber => $biblionumber } ); [...] + items => $items, Not needed, the biblio is passed already. At least 1. is blocker (security) IMO. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
