https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42295
--- Comment #21 from Jan Kissig <[email protected]> --- Created attachment 201695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201695&action=edit Bug 42295: (follow-up): Split JS block in js-patron-format-address.inc (auto tidy) This isolates the interpolation of Template::Toolkit variables in a separate script tag. The variables roadtypes and AddressFormat were moved outside the anonymous function body, AddressFormat is put in Koha.prefs store. This led to an 'redeclaration of const roadtypes' error as patrons-search.inc also included js-patron-format-address.inc. As js-patron-format-address.inc is always included via js_includes.inc it could safely be removed from patrons-search.inc. To test: - Open dev console and open a page with a patron search f.e. place a hold: /cgi-bin/koha/reserve/request.pl?biblionumber=262 - search for a patron and check that the address format is aligning with the syspref AddressFormat - change AddressFormat -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
