https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43059
--- Comment #3 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 201906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201906&action=edit Bug 43059: Migrate callers and remove GetMarcPrice/MungeMarcPrice Migrates all callers of C4::Biblio::GetMarcPrice to use Koha::Biblio::Metadata::Extractor->get_normalized_price: - acqui/addorderiso2709.pl - acqui/neworderempty.pl - Koha/MarcOrder.pm Removes GetMarcPrice and MungeMarcPrice from C4::Biblio. The existing MungeMarcPrice.t test (11 currency-aware price parsing cases) is preserved and migrated to test the extractor's _munge_price method directly. The original test in t/db_dependent/Biblio.t is updated to use the extractor as well. Test plan: 1. Apply this patch 2. Run: prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/MungeMarcPrice.t => SUCCESS: All tests pass 3. Verify no remaining callers: grep -rn 'GetMarcPrice\|MungeMarcPrice' --include='*.pm' --include='*.pl' => No results 4. Test acquisitions workflow: import a MARC file with price data in 020$c (MARC21) or 010$d (UNIMARC) => SUCCESS: Price is correctly extracted into order form -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
