https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072
Bug ID: 43072
Summary: Hold policies display incorrectly in circ rules page
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Hold requests
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected], [email protected],
[email protected]
Depends on: 41267
Target Milestone: ---
Bug 41267 added a new hold policy type to the "Default holds and bookings
policies by item type" section at the bottom of the page, "Fill other record
level holds on record at checkout." If this policy is set to Yes or undefined,
an item of the given itemtype can fill a bib-level hold even if the itemtype
doesn't otherwise allow holds. If the policy is set to No, then the itemtype
will not fill record-level holds.
On upgrade, Bug 41267 does not set anything in the circulation_rules for this
policy.
After upgrade, any itemtype that has a value set for something else in this
section will show a value of "No" for "Fill other record level holds on record
at checkout" even though this policy isn't actually set.
So the upgrade doesn't actually change any circ behavior, but it shows an
erroneous change in the circ rules.
To recreate:
- be on a version of Koha without this code (25.11.04 or older)
- set Hold Policy = "No holds allowed" for an itemtype
- upgrade Koha to a version with this code
- reload the circ rules page, confirm the Default holds and bookings policies
by item type section still shows your Hold Policy value and *also* shows "Fill
other record level holds on record at checkout" set to "No" for your itemtype
- query "select * from circulation_rules where
rule_name='fill_other_biblio_holds_policy'" and confirm no rule exists in the
database
- confirm a record-level hold can still be filled with an item of your itemtype
- update your circ rules to actually save a No for "fill other record level
holds"
- confirm this now shows in your circ rules query
- confirm a hold no longer fills
It seems simplest to make this table show "Yes" when no policy exists.
But on the other hand in current main I cannot set any rule in this table
without also setting a "Fill other record level holds" value, so maybe it would
be more consisten to actually save a "Yes" rule for
'fill_other_biblio_holds_policy' on any itemtype that already has something set
for any other rule here.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41267
[Bug 41267] It should be possible to prevent some itemtypes from filling other
biblio level holds
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
