https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503
--- Comment #58 from Paul Derscheid <[email protected]> --- Thanks Tomás! A few things before passing QA: 1. The [DO NOT PUSH] schema patch (attachment 200559) is empty. The schema changes ended up in "Add materialized description columns". Also, the patron/pickup_library belongs_to aliases are below the md5 line, so they need to move to a regular patch ("Add holds queue REST API endpoint" already claims them). 2. The rename follow-up also drops !is_superlibrarian from the HidePatronName check. The change looks right, but it should be squashed into the endpoint patch? 3. No test coverage for HidePatronName in t/db_dependent/api/v1/holds_queue.t. 4. t/lib/sample_holds_queue.pl would be the first executable script in t/lib. Intentional, or should it live in misc/devel/? 5. Minor: does patron duplicate the existing borrower relationship because of the embed name? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
